Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #17: Install link of RankMath must change based on the plugin of origin #19

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

jeawhanlee
Copy link
Collaborator

Description

Fixes #17
Updates the plugin download url for rankmath to be custom.

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Detailed scenario

N/A

Technical description

Documentation

Returns custom plugin download url for rankmath.

New dependencies

N/A

Risks

N/A

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Unticked items justification

No endpoint to protect, no message to output.

Additional Checks

  • In the case of complex code, I wrote comments to explain it.
  • When possible, I prepared ways to observe the implemented system (logs, data, etc.).
  • I added error handling logic when using functions that could throw errors (HTTP/API request, filesystem, etc.)

@jeawhanlee jeawhanlee self-assigned this Dec 20, 2024
@jeawhanlee jeawhanlee added the enhancement New feature or request label Dec 20, 2024
@jeawhanlee
Copy link
Collaborator Author

We need to check the counter @MathieuLamiot stated here in the AC

@jeawhanlee jeawhanlee requested a review from a team December 20, 2024 21:50
@hanna-meda
Copy link

hanna-meda commented Dec 24, 2024

For testing:

  1. Ensure there is no regression when clicking Install button:
  • download+install+activate happens with one-click.
  • user is kept on Our Plugins tab.
  1. Confirm that clicking the Install button for RankMath under the Our Plugins (family) section triggers the download and installation from custom URL:
    —> rankmath.com/downloads/plugin-family/imagify
    —> rankmath.com/downloads/plugin-family/wp-rocket
  2. Confirm that the download counter increments correctly after the button is clicked (from the RankMath team, opened thread on group.one slack #saas-eng-plugin-family).

^ Same workflow to be followed at both plugins, Imagify & WP-Rocket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install link of RankMath must change based on the plugin of origin
3 participants